Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3.1 basic compatability #18

Open
youreperfect opened this issue May 9, 2019 · 1 comment
Open

Fix 3.1 basic compatability #18

youreperfect opened this issue May 9, 2019 · 1 comment

Comments

@youreperfect
Copy link

This plugin isn't out-of-the-box compatible with 3.1 but the fix is prety easy - its just updating the enums to have the enum type name. Here are ones I remember doing:

inheritance_dock.gd line 35

const ICONS = {
	Mode.RES_MODE: RES_ICON,
	Mode.SCRIPT_MODE: SCRIPT_ICON,
	Mode.SCENE_MODE: SCENE_ICON
}
const CACHE_MAP = {
	Mode.RES_MODE: Caches.CACHE_RES,
	Mode.SCENE_MODE: Caches.CACHE_SCENE,
	Mode.SCRIPT_MODE: Caches.CACHE_SCRIPT
}

line 270:

					Mode.RES_MODE:

line 280:

Mode.SCENE_MODE, Mode.SCRIPT_MODE, _:

and so on. In general if you get an error then click the line and add Mode. before the enum value on that line. There are also errors reported for godot_inheritance_dock_plugin.gd but if I remember correctly they were just a side effect of the enum naming thing in inheritance_dock.gd

@youreperfect youreperfect changed the title Fix 3.1 compatability Fix 3.1 basic compatability May 9, 2019
@artism90
Copy link

artism90 commented Sep 9, 2023

This issue has been fixed by #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants