-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The plugin's resources are still in use during program exit. #11
Comments
This has something to do with the compilation of the RegEx objects in |
Maybe this isn't quite a memory leak. The error explicitly says...
And since it only happens at close, it might have less to do with calling compile itself, and more to do with the fact that the RegEx object is being actively used or triggered during shut down procedures. Which would only happen if the filter menu item's regex_edit node's text property is assigned a value at the same time that the RegEx object is being removed (which would actually make sense). |
Perhaps this could be "fixed" by not recompiling the regex unless the user manually clicks on a re-compile button within the FilterMenuItem. That would also prevent the editor from printing "cannot compile, bad regex!" errors every time you type a character into the Regex LineEdit. Edit: actually, it would be simpler to just have it trigger when the user explicitly clicks "ENTER" while on the LineEdit. Preserves the usability level without auto-triggering regex compilation every time the value is set. |
Currently, if you close the editor with the plugin active, you will see error messages. They are some memory leaks in the Inheritance Dock that I need to track down. For now, some errors will show up if you close the editor with the plugin active. (since it clears the resource cache and memory pool regardless.
The text was updated successfully, but these errors were encountered: