metrics: Migrate GrowthExperiments client code to statslib

Bug: T382003
Change-Id: I1f3229a9cef1ecf451085eb17709c00cf0748872

Author: Cyndy

bundlesize.config.json

@@ -1,6 +1,6 @@
 [
 	{
 		"resourceModule": "ext.growthExperiments.SuggestedEditSession",
-		"maxSize": "4.5 kB"
+		"maxSize": "4.7 kB"
 	}
 ]

modules/ext.growthExperiments.DataStore/GrowthTasksApi.js

@@ -486,18 +486,30 @@
 	};
 
 	/**
-	 * Log time spent since startTime to Statsd.
+	 * Log time spent since startTime to Statsd and Prometheus.
 	 *
 	 * @param {string} name Name of the thing (e.g. method call) that's timed.
 	 * @param {number} startTime Start timestamp, e.g. from mw.now().
 	 * @param {string} [contextOverride] Overrides the context provided in the constructor.
 	 * @private
 	 */
 	GrowthTasksApi.prototype.logTiming = function ( name, startTime, contextOverride ) {
+		const duration = mw.now() - startTime;
+		const platform = this.isMobile ? 'mobile' : 'desktop';
 		mw.track(
 			'timing.growthExperiments.specialHomepage.growthTasksApi.' + name + '.' +
-				( contextOverride || this.logContext ) + '.' + ( this.isMobile ? 'mobile' : 'desktop' ),
-			mw.now() - startTime
+			( contextOverride || this.logContext ) + '.' + platform, duration );
+
+		mw.track(
+			'stats.mediawiki_GrowthExperiments_special_homepage_seconds',
+			duration,
+			{
+				module: 'growthTasksApi',
+				operation: name,
+				context: contextOverride || this.logContext,
+				platform: platform,
+				wiki: mw.config.get( 'wgDBname' )
+			}
 		);
 	};
 

modules/ext.growthExperiments.Homepage.Impact/App.vue

@@ -76,7 +76,17 @@ module.exports = exports = {
 	},
 	methods: {
 		impactMounted: function () {
-			mw.track( 'timing.growthExperiments.newImpact.' + inject( 'RENDER_MODE' ) + '.mounted', mw.now() - startTime );
+			const duration = mw.now() - startTime;
+			mw.track( 'timing.growthExperiments.newImpact.' + inject( 'RENDER_MODE' ) + '.mounted', duration );
+			mw.track(
+				'stats.mediawiki_GrowthExperiments_homepage_impact_mounted_seconds',
+				duration,
+				{
+					// eslint-disable-next-line camelcase
+					render_mode: inject( 'RENDER_MODE' ),
+					wiki: mw.config.get( 'wgDBname' )
+				}
+			);
 		}
 	}
 };

modules/ext.growthExperiments.Homepage.SuggestedEdits/index.js

@@ -65,26 +65,39 @@
 		}
 
 		suggestedEditsModule.updateControls();
+
+		const clientSideLoadDuration = mw.now() - initTime, // Time since module init
+			serverDuration = mw.now() - mw.config.get( 'GEHomepageStartTime' );
 		// Track the TTI on client-side.
 		mw.track(
 			'timing.growthExperiments.specialHomepage.modules.suggestedEditsTimeToInteractive.' +
 			( OO.ui.isMobile() ? 'mobile' : 'desktop' ),
-			mw.now() - initTime
+			clientSideLoadDuration
+		);
+		mw.track(
+			'stats.mediawiki_GrowthExperiments_suggested_edits_tti_seconds',
+			clientSideLoadDuration,
+			{
+				platform: OO.ui.isMobile() ? 'mobile' : 'desktop',
+				// eslint-disable-next-line camelcase
+				includes_server_response_time: false
+			}
 		);
 		// Track the server side render start time (first line in SpecialHomepage#execute()) to
 		// TTI on client-side.
 		mw.track(
 			'timing.growthExperiments.specialHomepage.modules.suggestedEditsTimeToInteractive.serverSideStartInclusive.' +
 			( OO.ui.isMobile() ? 'mobile' : 'desktop' ),
-			mw.now() - mw.config.get( 'GEHomepageStartTime' )
+			serverDuration
 		);
-		// FIXME: suggestedEditsLoadingComplete could probably be removed as it is now a duplicate of
-		// suggestedEditsTimeToInteractive. We can leave it for now in case we decide to rollback this change
-		// or make other adjustments in loading behavior.
 		mw.track(
-			'timing.growthExperiments.specialHomepage.modules.suggestedEditsLoadingComplete.' +
-			( OO.ui.isMobile() ? 'mobile' : 'desktop' ),
-			mw.now() - initTime
+			'stats.mediawiki_GrowthExperiments_suggested_edits_server_tti_seconds',
+			serverDuration,
+			{
+				platform: OO.ui.isMobile() ? 'mobile' : 'desktop',
+				// eslint-disable-next-line camelcase
+				includes_server_response_time: true
+			}
 		);
 		return $.Deferred().resolve();
 	}

modules/ext.growthExperiments.SuggestedEditSession/index.js

@@ -620,10 +620,22 @@
 		if ( !this.startTime || !this.shouldTrackPerformance ) {
 			return;
 		}
+		const duration = window.performance.now() - this.startTime;
 		mw.track(
 			'timing.growthExperiments.suggestedEdits.taskEditorReady.' + this.taskType +
 			( OO.ui.isMobile() ? '.mobile' : '.desktop' ),
-			window.performance.now() - this.startTime
+			duration
+		);
+		mw.track(
+			'stats.mediawiki_GrowthExperiments_task_editor_ready_seconds',
+			duration,
+			{
+				// eslint-disable-next-line camelcase
+				task_type: this.taskType,
+				platform: ( OO.ui.isMobile() ? 'mobile' : 'desktop' ),
+				operation: 'editor_shown',
+				wiki: mw.config.get( 'wgDBname' )
+			}
 		);
 	};
 
@@ -639,10 +651,22 @@
 		if ( this.shouldOpenArticleInEditMode || !this.startTime || !this.shouldTrackPerformance ) {
 			return;
 		}
+		const guidanceDisplayDuration = window.performance.now() - this.startTime;
 		mw.track(
 			'timing.growthExperiments.suggestedEdits.guidanceShown.' + this.taskType +
 			( OO.ui.isMobile() ? '.mobile' : '.desktop' ),
-			window.performance.now() - this.startTime
+			guidanceDisplayDuration
+		);
+		mw.track(
+			'stats.mediawiki_GrowthExperiments_suggested_edits_session_seconds',
+			guidanceDisplayDuration,
+			{
+				// eslint-disable-next-line camelcase
+				task_type: this.taskType,
+				platform: ( OO.ui.isMobile() ? 'mobile' : 'desktop' ),
+				operation: 'guidance_shown',
+				wiki: mw.config.get( 'wgDBname' )
+			}
 		);
 	};
 

modules/homepage.init.js

@@ -22,6 +22,15 @@
 				'timing.growthExperiments.specialHomepage.navigationDuration',
 				navigationEntries[ 0 ].duration
 			);
+			mw.track(
+				'stats.mediawiki_GrowthExperiments_navigation_duration_seconds',
+				navigationEntries[ 0 ].duration,
+				{
+					// eslint-disable-next-line camelcase
+					navigation_type: navigationEntries[ 0 ].type,
+					wiki: mw.config.get( 'wgDBname' )
+				}
+			);
 			mw.track(
 				// Using 'timing' for transfer size sounds conceptually wrong, but we want
 				// the various features that statsd timing gives us (see
@@ -35,6 +44,13 @@
 				'timing.growthExperiments.specialHomepage.paintStartTime',
 				performanceEntries[ 0 ].startTime
 			);
+			mw.track(
+				'stats.mediawiki_GrowthExperiments_paint_start_seconds',
+				performanceEntries[ 0 ].startTime,
+				{
+					platform: OO.ui.isMobile() ? 'mobile' : 'desktop'
+				}
+			);
 		}
 	}