Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check to hide loadingTemplate #7490

Open
dheldt opened this issue Sep 6, 2024 · 1 comment
Open

Improve check to hide loadingTemplate #7490

dheldt opened this issue Sep 6, 2024 · 1 comment

Comments

@dheldt
Copy link

dheldt commented Sep 6, 2024

Description

Currently, the check if the loadingTemplate is hidden is based on an if-statement, checking if the (re-)loading is silent. Please adept this to check, if the loadingTemplate is visible.

Background: The last three days i did debug an app, where we have a slow server response (~10 seconds due to a huge database and complicated filters). The app auto-reloads silently, but the initial load is not.

The first reload was triggered (sometimes) before the initial load was completed. In this cases, the check to remove the loadingTemplate failed (it was visible due to the intial load not being completed, but the silent reload set the corresponding setting to silent). So the loadingTemplate was never hidden an no data were visible.

I guess it is not to hard to check, if it is visible, instead of relying on the setting, which might have been changed?

Surely, the issue i debugged was in my code by reloading to early, still I think bootstrap-table can be improved here to be more reliant (and prevent maybe somebody else some debugging-time).

thank you!

with kind regards,

daniel

@wenzhixin
Copy link
Owner

Please provide an Online Example to show your problem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants