-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long redirects urls and paths don't shorten in the UI #4944
Labels
complexity:low
Good for newcomers, up to a few days of work
prio:1
The most important thing to work on
type:bug
Something isn't working
Comments
3 ideas:
On top of that an edit button is also nice to have, in situations I only need to change a letter or a / in the url redirect |
@Blazing-Mike feel free to send the pr |
should i send a PR just for break line or i should go ahead with adding an edit button? |
@Blazing-Mike separate prs pls |
7 tasks
kof
added a commit
that referenced
this issue
Mar 13, 2025
…4988) ## Description fix issue #4944 long redirect urls don't shorten, they extend across Project seetings container and parts of it disappears which make UI looks broken. i added a word-break to the links, set a width for old link and max-width for the new-path link.  ## Steps for reproduction 1. click on Menu button 2. click on "Project settings" Menu item 3. Click on the Redirects on the sidebar 4. Input old-path and new-path or URL 5. Click Add ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [x] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [x] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file --------- Co-authored-by: Oleg Isonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
complexity:low
Good for newcomers, up to a few days of work
prio:1
The most important thing to work on
type:bug
Something isn't working
Discussion
In theory they should be shortened but there is no max width set, so path or url can be long and can make the UI look broken.
The text was updated successfully, but these errors were encountered: