Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to customize MAX_DEDUPLICATION_INCREMENT into ImmutableSlugValueHandler #80

Open
lruozzi9 opened this issue May 6, 2021 · 0 comments
Open

Ability to customize MAX_DEDUPLICATION_INCREMENT into ImmutableSlugValueHandler #80

lruozzi9 opened this issue May 6, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lruozzi9
Copy link
Member

lruozzi9 commented May 6, 2021

The MAX_DEDUPLICATION_INCREMENT constant in the ImmutableSlugValueHandler should be injected into the class. So, for the stores where more than 100 products have the same name, could increment this constant without override the entire service.
@lruozzi9 lruozzi9 added enhancement New feature or request good first issue Good for newcomers labels May 6, 2021
lruozzi9 added a commit to lruozzi9/SyliusAkeneoPlugin that referenced this issue May 6, 2021
@lruozzi9
Add max slug deduplication increment dependency to slug generator (we…
204dfa8 
…bgriffe#80)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lruozzi9