Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods building ci/cd check #771

Closed
yaroslavyaroslav opened this issue Feb 9, 2023 · 1 comment
Closed

Cocoapods building ci/cd check #771

yaroslavyaroslav opened this issue Feb 9, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yaroslavyaroslav
Copy link
Collaborator

What context is your feature request related to?

There's still no ci/cd pipeline for a cocoapods release.

What solution would you like?

Such pipeline has to be implemented as long as we're providing cocoapods support (which is for now until 3.*.* release branch are active).

Requirements

  1. This pipeline should be implemented for both modules: Web3Code.podspec and Web3Swift.podspec.
  2. This pipeline should be triggered only on developer to master merge, as cocoapods support are just an additional feature of our lib, and it's never in first place in development process.

So in case of new code has been broke cocoapods in a some way a release should be provided in SPM anyway, while the cocoapods release would be provided in future by a separate patch by fixup PR into develop.

So as it said above, those checks would not be a merge or release blockers as pod releases happening manually yet, they just to be proposed to made cocoapods release more convenient to a maintainer.

Any additional context?

An appropriate way to check whether pod is building locally (e.g. that the code is ok ready to be published) is: pod lib lint --allow-warnings POD_NAME.podspec

@yaroslavyaroslav yaroslavyaroslav added enhancement New feature or request good first issue Good for newcomers labels Feb 9, 2023
@JeneaVranceanu
Copy link
Collaborator

@yaroslavyaroslav Closing this as now we plan to drop the support of CocoaPods: #829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants