From 6f1558a74c6ef1f52085a594cae98744b260ef6a Mon Sep 17 00:00:00 2001 From: Daniil Sakhapov Date: Mon, 24 Feb 2025 04:50:19 -0800 Subject: [PATCH] [carousel] Fix AttachLayoutTree for ::scroll-marker expecting parent If ::scroll-marker is inside the element that requires style recalc, but not layout, context.parent is nullptr. So, we have to if() attachment instead of CHECK(context.parent). Fixed: 394980089 Change-Id: Iefdc99a1b65cabeb91d1cf5d7f79e47a0a787e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6298048 Reviewed-by: Rune Lillesveen Commit-Queue: Daniil Sakhapov Cr-Commit-Position: refs/heads/main@{#1423840} --- .../scroll-markers-inside-canvas-crash.html | 11 +++++++++++ .../scroll-markers-inside-select-crash.html | 16 ++++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 css/css-overflow/scroll-markers-inside-canvas-crash.html create mode 100644 css/css-overflow/scroll-markers-inside-select-crash.html diff --git a/css/css-overflow/scroll-markers-inside-canvas-crash.html b/css/css-overflow/scroll-markers-inside-canvas-crash.html new file mode 100644 index 00000000000000..523c8823effe1c --- /dev/null +++ b/css/css-overflow/scroll-markers-inside-canvas-crash.html @@ -0,0 +1,11 @@ + + + +
+ +
You don't see me
+ +
diff --git a/css/css-overflow/scroll-markers-inside-select-crash.html b/css/css-overflow/scroll-markers-inside-select-crash.html new file mode 100644 index 00000000000000..a7a0b64cd64cef --- /dev/null +++ b/css/css-overflow/scroll-markers-inside-select-crash.html @@ -0,0 +1,16 @@ + + + +