Skip to content

Commit 413e248

Browse files
pastjgraham
andauthoredOct 1, 2024
Clarify details around review approvals before merging (#199)
* Clarify details around review approvals before merging * Address Philip's feedback * Update README.md Co-authored-by: jgraham <[email protected]> * Update README.md Co-authored-by: jgraham <[email protected]> --------- Co-authored-by: jgraham <[email protected]>
1 parent c10040b commit 413e248

File tree

1 file changed

+18
-3
lines changed

1 file changed

+18
-3
lines changed
 

‎README.md

+18-3
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,24 @@ Cases where the RFC process need *not* be used:
3737
* Risks
3838
- The proposal is discussed by the community and it is assumed that the
3939
proposal will change in accordance with that discussion.
40-
- In the case of no substantive disagreement the RFC is considered accepted
41-
after 1 week. If any participant requests it, the comment period is extended
42-
to 2 weeks.
40+
- At least one review approval is required to merge a PR. For changes that
41+
may impact downstream WPT consumers there is an additional requirement
42+
of agreement from those consumers that the proposed change can be
43+
accommodated in their workflows.
44+
- Anyone is welcome to add the PR to the monthly
45+
[WPT infra meeting](https://github.com/web-platform-tests/wpt-notes) to
46+
have a dsicsussion about it. To add an RFC to the agenda, tag the PR with the
47+
`agenda+` label.
48+
- If reviewers or downstream consumers are not responsive after at least two
49+
weeks, the PR should be added to the monthly
50+
[WPT infra meeting](https://github.com/web-platform-tests/wpt-notes) to
51+
ensure it gets discussed.
52+
- After review approval(s) and in the case of no substantive disagreement, the
53+
RFC is considered accepted 1 week after the first approval. If any participant
54+
requests it, more time can be granted to review the proposal. This will not be
55+
less than one week but may be longer (e.g. until the next WPT infra meeting).
56+
However if no feedback is forthcoming by the agreed date, the proposal may
57+
be considered accepted.
4358
- If substantive disagreement remains, then the issue is escalated to the
4459
[core team](https://github.com/orgs/web-platform-tests/teams/wpt-core-team/)
4560
for a decision:

0 commit comments

Comments
 (0)