Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: checkDeadLinks is unavailable for custom react components #1355

Closed
zmzlois opened this issue Aug 28, 2024 · 1 comment
Closed

[Bug]: checkDeadLinks is unavailable for custom react components #1355

zmzlois opened this issue Aug 28, 2024 · 1 comment
Labels
🐞 bug Something isn't working

Comments

@zmzlois
Copy link
Contributor

zmzlois commented Aug 28, 2024

Version

System:
    OS: macOS 14.2.1
    CPU: (12) arm64 Apple M2 Pro
    Memory: 45.59 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 128.0.6613.85
    Edge: 128.0.2739.42
    Safari: 17.2.1
  npmPackages:
    @rspress/mdx-rs: ^0.5.7 => 0.5.7 
    @rspress/plugin-shiki: ^1.23.1 => 1.23.1 
    rspress: ^1.18.1 => 1.18.1

Details

We have some custom react components on our website, but the checkDeadLinks seemed to be unavailable for links in these components

Reproduce link

https://github.com/ZephyrCloudIO/zephyr-documentation

Reproduce Steps

  1. run npm run install && npm run dev
  2. Click on cards on Recipes page
  3. links are broken but nothings shows up on console
@zmzlois zmzlois added the 🐞 bug Something isn't working label Aug 28, 2024
@Timeless0911
Copy link
Collaborator

Timeless0911 commented Aug 28, 2024

This is as expected. checkDeadLinks only statically parse the link syntax [xx](xx)directly in the mdx file and cannot dynamically analyze the component props of tsx since syntax static analysis cannot do this.

@zmzlois zmzlois closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants