Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Minimizing CSS using lightningcss may shuffle the CSS property order #7921

Open
matthiask opened this issue Sep 18, 2024 · 0 comments
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.

Comments

@matthiask
Copy link

matthiask commented Sep 18, 2024

System Info

System:
OS: Linux 6.10 Fedora Linux 40 (Workstation Edition)
CPU: (16) x64 11th Gen Intel(R) Core(TM) i7-11700F @ 2.50GHz
Memory: 54.73 GB / 62.62 GB
Container: Yes
Shell: 5.2.26 - /bin/bash
Binaries:
Node: 20.12.2 - /usr/bin/node
Yarn: 4.4.1 - /usr/bin/yarn
npm: 10.5.0 - /usr/bin/npm
pnpm: 9.0.6 - /usr/bin/pnpm

Details

This is more of a heads up since it's actually a bug in lightningcss tracked here:
parcel-bundler/lightningcss#805

The report over there also contains a reproduction. I'm opening this issue with the goal of raising awareness about this issue, and also to ask if the option exists to bring the SWC CSS minimizer back.The SWC minimizer seems to be a bit more conservative which makes breakages such as this one less likely. Of course fixing lightningcss would probably be even better... :-)

Also, having an issue in the rspack repository may help others who are running into the same problem.

The bug was introduced between 0.7.5 and 1.0.0-alpha.0.

Reproduce link

No response

Reproduce Steps

A minimal lightningcss reproduction case is mentioned in the lightning CSS issue:
parcel-bundler/lightningcss#805

@matthiask matthiask added bug Something isn't working pending triage The issue/PR is currently untouched. labels Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending triage The issue/PR is currently untouched.
Projects
None yet
Development

No branches or pull requests

1 participant