-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated docs, improve naming, prefer user props over auth hook in docs #2535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I will leave approving to @infomiho though, since he knows the Auth part better.
@@ -8,6 +8,7 @@ | |||
/docs/deploying /docs/deployment/intro 301 | |||
/docs/advanced/deployment/overview /docs/deployment/intro 301 | |||
/docs/integrations/css-frameworks /docs/project/css-frameworks 301 | |||
/docs/data-model/backends /docs/data-model/databases 301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm but this is probably not 1 on 1 mapping? I am guessing that backends was wider than just databases? If it is just name change then makews sense, but if not and backends was wider, maybe better not to map at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine - the backends refered to "database backends". The new "databases" site is exactly that with a couple of extra sentences and an extra title added on top.
@@ -8,6 +8,7 @@ | |||
/docs/deploying /docs/deployment/intro 301 | |||
/docs/advanced/deployment/overview /docs/deployment/intro 301 | |||
/docs/integrations/css-frameworks /docs/project/css-frameworks 301 | |||
/docs/data-model/backends /docs/data-model/databases 301 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine - the backends refered to "database backends". The new "databases" site is exactly that with a couple of extra sentences and an extra title added on top.
@FranjoMindek did I get something wrong, or did you add quite some changes after my last review -> what happened there? Are those still in the initial scope of this PR, or are these additional fixes? |
Initial commit didn't capture all places referencing the old name of the document. I've added rest of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. I'm approving but left some suggestions
await
forsanitizeAndSerializeProviderData
callsdata-model/backends
todata-model/databases
user
props rather thanuseAuth()
, also reflected on examplesRelated issues: #2514, #1071