Introduce middleware for job error handling #2502
Conversation
Fixes wasp-lang#2475 Introduce default error logging middleware for jobs to avoid server crashes. * Add `errorLoggingMiddleware` function in `waspc/data/Generator/templates/sdk/wasp/server/middleware/globalMiddleware.ts` to log errors and prevent job crashes. * Update `mage/src/server/jobs/checkForPendingApps.ts` to wrap the `checkForPendingApps` job handler with `errorLoggingMiddleware`. * Update `mage/src/server/jobs/failStaleGenerations.ts` to wrap the `failStaleGenerations` job handler with `errorLoggingMiddleware`. * Update documentation in `web/docs/advanced/jobs.md` to include information about the new default error logging middleware for jobs. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/wasp-lang/wasp/issues/2475?shareId=XXXX-XXXX-XXXX-XXXX).
|
Thanks for the contribution, did you test this locally successfully? |
|
Yes, I have tested these changes locally. |
|
I'm closing this PR since it doesn't cover the full scope of the linked issue, primarily:
The research for this feature is missing and we want to probably build a job's middleware system with maybe some defaults (or not, I can't be sure without trying to build the API). Ideally, we'd have a general enough middleware system for jobs like we do for APIs. We want to do something similar for operations as well #2396 If possible @pshycodr please ping us first on Discord when you'd like to work on issue so we can discuss the direction that makes sense :) thank you for your effort! Locally testing this PRRunning Mage locally gives me errors which reveal that the The helper should be typed as a generic function so it's a "pass-through" function that keeps the input and output types of the job function. |
Fixes #2475
Introduce default error logging middleware for jobs to avoid server crashes.
errorLoggingMiddlewarefunction inwaspc/data/Generator/templates/sdk/wasp/server/middleware/globalMiddleware.tsto log errors and prevent job crashes.mage/src/server/jobs/checkForPendingApps.tsto wrap thecheckForPendingAppsjob handler witherrorLoggingMiddleware.mage/src/server/jobs/failStaleGenerations.tsto wrap thefailStaleGenerationsjob handler witherrorLoggingMiddleware.web/docs/advanced/jobs.mdto include information about the new default error logging middleware for jobs.