Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from golang openpgp #439

Open
MatthewJohn opened this issue May 29, 2024 · 2 comments · Fixed by #435
Open

Move away from golang openpgp #439

MatthewJohn opened this issue May 29, 2024 · 2 comments · Fixed by #435

Comments

@MatthewJohn
Copy link
Collaborator

According to the docs: https://pkg.go.dev/golang.org/x/crypto/openpgp, the library has been deprecated:

Deprecated: this package is unmaintained except for security fixes. New applications should consider a more focused, modern alternative to OpenPGP for their specific task. If you are required to interoperate with OpenPGP systems and need a maintained package, consider a community fork. See https://golang.org/issue/44226. 

It seems that quite a few have suggested/have moved to https://github.com/ProtonMail/gopenpgp
This arose whilst trying to write some tests: c25d831

@yermulnik
Copy link
Collaborator

Just cross-posting for visibility: #435 (comment)

I wonder if these tests can immediately start using Proton Mail's library to see if it resolves the issues

I'd say go ahead with it.

@MatrixCrawler MatrixCrawler linked a pull request Jun 4, 2024 that will close this issue
@MatthewJohn
Copy link
Collaborator Author

Re-opening as gopenpgp was only used for some mocking tests - the original use of openpgp is still in use

@MatthewJohn MatthewJohn reopened this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants