-
-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles not reloading correctly in DEV mode of example app 37_css #1241
Comments
Confirmed the issue. For me, it reproduces with 04_cssmodules too. Can you help investigating the issue? The first thing we would like to know is if this is a regression with some changes. You can check out some previous commits and run: git switch --detach ...
pnpm i
pnpm -F ./packages/waku compile
pnpm -F 37_css dev instead of changing the directory. |
Having this issue as well, Ill dig into the example, but from first glance:
|
I traced it back 0.18.0 and had trouble getting anything earlier running. The issue seems to always be there. At 0.18.0 the issue changed a bit, but I'm assuming this is related to the full page reload VS the hot reload. Here is a video: https://share.cleanshot.com/PLM8Sffl |
Interestingly, testing |
Wes, thanks so much for looking into it. It sounds like it's not a regression, and it has never worked before. To be honest, our team lacks css specialists. Hope @Aslemammad has time to help. Otherwise, I should take a closer look later. As for stylex, I'd say it's not working correctly in several aspects. We track the issue in #750. |
Looks like next/webpack suffers the same issue, though I never had it with my next site vercel/next.js#57046 |
Environment:
Issue
When editing a style in the example application
37_css
the new style is not automatically loaded and requires a manual refresh in the browser. HMR is triggered and the old style is not visible anymore, but to see the new style applied a manual refresh is required.Reproducible steps
app.module.css
change thebackground-color
to another color valueExtra Info
I notice this is not an issue in the example app
04_cssmodules
. Might be related to the different routing? I also have this issue in my own application where I solely use css modules, but I do use the routing approach from example37_css
instead of the file system based routing.The text was updated successfully, but these errors were encountered: