Only break circular dependencies at a soft dependency #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilytoppm
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
This looks good to me - we should definitely not be breaking hard dependencies if there are soft ones available. However, it feels like for circular dependencies, there is another desirable step: to re-import the affected fields after the circle is resolved and restore the links. Because at the end of the import process, we do still have the page being linked to, unlike the "outside the import tree" scenario. Breaking the link rather than failing is definitely better, but from a user's perspective, it's still hard to explain behaviour. What do you think?
|
Definitely - I think implementing that would be a much harder task, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84. Where a circular dependency consists of a combination of soft and hard dependencies - for example, a grandchild page exists under a parent page (hard dependency) which exists under a grandparent page (hard dependency) which contains a rich text link to the grandchild page (soft dependency) - we can complete the import only by breaking the dependency chain at the soft dependency (i.e. omitting the rich text link). Previously, we were breaking the chain at the point where we discovered the circularity, which would fail if that was a hard dependency.