Skip to content

Commit fac605c

Browse files
committed
Rename "prepare" script to "curate" to prevent auto-runs
The `prepare` script is run when the repository is installed. On top of creating issues when the repository is set as dependency in another project for some reason, as described in: #789 (comment) ... this also seems wrong because: 1. There is no guarantee that the curation will run without errors. A patch may no longer apply for instance. 2. Projects may want to depend on the raw data and may not need to run the curation and package preparation logic at all. This update replaces the "prepare" script with a "curate" one, explicitly called in the jobs that need it.
1 parent 908cef4 commit fac605c

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

Diff for: .github/workflows/curate.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,12 @@ jobs:
3434
# the curated branch
3535
fetch-depth: 0
3636

37-
- name: Prepare curated and packages data
38-
# Note that "ci" runs the "prepare" script
37+
- name: Install dependencies
3938
run: npm ci
4039

40+
- name: Prepare curated and packages data
41+
run: npm run curate
42+
4143
- name: Test curated and packages data
4244
run: npm run test
4345

Diff for: .github/workflows/test.yml

+6-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@ jobs:
1010
- uses: actions/setup-node@v2
1111
with:
1212
node-version: '14'
13-
- run: npm ci
14-
- run: npm test
13+
- name: Install dependencies
14+
run: npm ci
15+
- name: Prepare curated and packages data
16+
run: npm run curate
17+
- name: Test curated and packages data
18+
run: npm test
1519
env:
1620
FORCE_COLOR: 3

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
},
4242
"scripts": {
4343
"create-patch": "node tools/create-patch.js",
44-
"prepare": "node tools/prepare-curated.js ed curated && node tools/prepare-packages.js curated packages",
44+
"curate": "node tools/prepare-curated.js ed curated && node tools/prepare-packages.js curated packages",
4545
"test": "mocha --recursive",
4646
"test-css": "mocha --recursive test/css",
4747
"test-elements": "mocha --recursive test/elements",

0 commit comments

Comments
 (0)