Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks option in favor of loading from implementation configs. #97

Closed
BigBlueHat opened this issue Jul 29, 2024 · 2 comments
Closed
Assignees

Comments

@BigBlueHat
Copy link
Member

BigBlueHat commented Jul 29, 2024

@PatStLouis @BigBlueHat so DB needs checks: ['proof'] but other implementers might not need that option and further options.checks has not be in the VC API for awhile so the best way to handle this is to add options.checks to the DB implementation and do something like this:

https://github.com/w3c-ccg/data-integrity-test-suite-assertion/blob/6d61d0f3940694edb12437bcb0f457a8b7cb56cb/assertions.js#L25-L46

How to handle this situation in the bitstring status list suite is another issue as those tests will probably need us to expose a second verify with the correct checks for our verifier.

Originally posted by @aljones15 in #92 (comment)

@BigBlueHat BigBlueHat changed the title @PatStLouis @BigBlueHat so DB needs checks: ['proof'] but other implementers might not need that option and further options.checks has not be in the VC API for awhile so the best way to handle this is to add options.checks to the DB implementation and do something like this: Remove checks option in favor of loading from implementation configs. Jul 29, 2024
@BigBlueHat BigBlueHat self-assigned this Jul 29, 2024
@BigBlueHat
Copy link
Member Author

@BigBlueHat
Copy link
Member Author

BigBlueHat commented Aug 1, 2024

From @aljones15 in #92 (comment):

@BigBlueHat so the DB verifier now has the checks in the options here: https://github.com/w3c/vc-test-suite-implementations/blob/9a014669b6f62ed9c1a920ef9e054c510abefe6c/implementations/DigitalBazaar.json#L82-L91

so you can now pass the verifier's implementation specific options to each verifier which might result in failure or more success LMK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant