Skip to content

Commit 5d4add0

Browse files
tidoustdontcallmedom
authored andcommitted
Run IDL analyses on curated branch, enable noEvent
This duplicates the calls to Strudy in the analysis job: first pass analyzes the raw crawl results, second pass runs further analyses (not the same ones!) on the curated crawl results. IDL analyses are now done as part of the second pass. The rationale is that some IDL anomalies may be indirectly triggered by another IDL hiccup that we already identified and reported while doing data curation in Webref. This makes it at least theoretically possible to end up in a situation where we detect an anomaly twice (from two different angles). It seems better to run further IDL analyses on the curated branch instead. This is particularly needed for the new `noEvent` anomaly, which would otherwise report problems that our events patching already takes care of. The `noEvent` anomaly will create two issues next time the job runs: - one for `HTMLBodyElement.onorientationchange`, already covered in the spec: https://compat.spec.whatwg.org/#windoworientation-interface - one for `RTCIceTransport.onerror`, already tracked in: w3c/webrtc-ice#47
1 parent fb6cec0 commit 5d4add0

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

.github/workflows/file-issue-for-review.yml

+16-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
git config user.email "<>"
2929
git remote set-url --push origin https://x-access-token:${{ secrets.ISSUE_REPORT_GH_TOKEN }}@github.com/$GITHUB_REPOSITORY
3030
working-directory: strudy
31-
- name: Run Strudy to detect new anomalies
31+
- name: Analyze the raw crawl results
3232
working-directory: strudy
3333
run: |
3434
node strudy.js inspect ../webref \
@@ -37,10 +37,24 @@ jobs:
3737
--cc ${{ vars.CC }} \
3838
--what brokenLinks \
3939
--what discontinuedReferences \
40+
--what missingTask
41+
- name: Switch to the curated branch
42+
working-directory: webref
43+
# Note: final "--" makes it clear that we're talking about the branch
44+
# and not the folder. The "curated" folder should not exist in a job
45+
# context, but better err on the safe side!
46+
run: git checkout curated --
47+
- name: Analyze the curated crawl results
48+
working-directory: strudy
49+
run: |
50+
node strudy.js inspect ../webref \
51+
--issues issues \
52+
--update-mode untracked \
53+
--cc ${{ vars.CC }} \
4054
--what incompatiblePartialIdlExposure \
4155
--what unexpectedEventHandler \
4256
--what wrongCaseEnumValue \
43-
--what missingTask
57+
--what noEvent
4458
- name: Run issue filer script
4559
working-directory: strudy
4660
run: node src/reporting/file-issue-for-review.js --max 10

0 commit comments

Comments
 (0)