Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Graph Comparison section to immediately after the sections defining graphs and terms #134

Closed
afs opened this issue Jan 17, 2025 · 5 comments · Fixed by #142
Closed

Comments

@afs
Copy link
Contributor

afs commented Jan 17, 2025

The graph comparison section is important so put it immediately after the sections defining terms.

Suggetsed new order:

  1. RDF Graphs
    3.1 Triples
    3.2 IRIs
    3.3 Literals
    3.4 Blank Nodes
    3.5 Triple Terms
    3.6 Graph Comparison
    3.7 Initial Text Direction
    3.8 Replacing Blank Nodes with IRIs
@afs afs changed the title Move Graph Comparison section to immediately after the terms definition sections Move Graph Comparison section to immediately after the sections defining graphs and terms Jan 17, 2025
@hartig
Copy link
Contributor

hartig commented Jan 19, 2025

With PR #140 merged, this change can be implemented now.

@afs
Copy link
Contributor Author

afs commented Jan 19, 2025

This is still an issue marker in that section but the issue is now closed.
I will remove the issue note in the PR - it can be put back if needed.

@gkellogg
Copy link
Member

Best thing is for PRs to remove issue markers they resolve.

@hartig
Copy link
Contributor

hartig commented Jan 20, 2025

It appears that the issue marker wasn't present in the first place in the branch of my PR #140. I guess I created that branch from main before the PR that added all the issue markers was merged.

I agree that removing the issue marker should be part of the PR that addresses the corresponding issue.

@afs
Copy link
Contributor Author

afs commented Jan 20, 2025

No problem - I'll remove it.

As we mostly use rebase-and-merge, the boundaries of PRs isn't recorded long term in the git history.
Which is good for small PRs because they end up as x2 log entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants