Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Breaks browser history navigation via keybinding #1638

Closed
amarshall opened this issue Mar 15, 2025 · 2 comments
Closed

[Bug report] Breaks browser history navigation via keybinding #1638

amarshall opened this issue Mar 15, 2025 · 2 comments
Labels
discussion Discussion

Comments

@amarshall
Copy link

Description

  1. Visit https://vuepress.vuejs.org/
  2. Press Guide → Configuration
  3. Press alt to navigate to the previous page using the standard browser keybinding
  4. Expect: to be back on https://vuepress.vuejs.org, as that was the last visited page.
    Actual: now on https://vuepress.vuejs.org/guide/getting-started.html, which I never visited, and the correct browser history is now lost.

Using Firefox on Linux. I only use VuePress as a user of documentation in other projects, I found this issue using docs for a different project, and it occurs in the VuePress docs as well. I briefly tried browsing the source code to find the problematic keybinding, but couldn’t find anything obvious, unfortunately, and the lack of source maps on the official doc page made it difficult to pinpoint the event binding.

Reproduction

https://vuepress.vuejs.org/

Used Package Manager

npm

System Info

n/a
@Mister-Hope
Copy link
Member

The forward and back are set according to sidebar/page nav, which will activate prev and next button at the bottom at the page.

Note: this feature won't spoil your history, only key bindings are added.

@Mister-Hope Mister-Hope closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2025
@Mister-Hope Mister-Hope added the discussion Discussion label Mar 16, 2025
@amarshall
Copy link
Author

Indeed the history is not actually broken, but it appears broken because the keybinding for “go back” has been overloaded to mean something else. I hope that you will consider changing the keybinding to not conflict with default browser behavior as it causes confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Discussion
Projects
None yet
Development

No branches or pull requests

2 participants