Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark is inaccurate #269

Open
LittleSound opened this issue Aug 18, 2024 · 1 comment
Open

Benchmark is inaccurate #269

LittleSound opened this issue Aug 18, 2024 · 1 comment
Assignees
@LittleSound

Comments

@LittleSound
Copy link
Member

The benchmark timer ends at the wrong position, which is related to the use of requestIdleCallback, as it gets triggered at the wrong time.

image

It sometimes causes rendering to slow down.

image
@LittleSound LittleSound self-assigned this Aug 18, 2024
@LittleSound LittleSound removed their assignment Sep 26, 2024
@LittleSound LittleSound mentioned this issue Nov 4, 2024
Merged
@LittleSound LittleSound self-assigned this Nov 13, 2024
@LittleSound
Copy link
Member Author

I'm redoing a more accurate performance test based on Vitest. I will submit a PR with in this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LittleSound LittleSound

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LittleSound