Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-vapor): fix slots render level mess up #241

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(runtime-vapor): fix slots render level mess up #241

wants to merge 5 commits into from

Conversation

Doctor-wu
Copy link
Member

@Doctor-wu Doctor-wu commented Jun 19, 2024 •
edited
Loading

close #242

  • fix runtime
  • add test case

@netlify Netlify
Copy link

netlify bot commented Jun 19, 2024 •
edited
Loading

✅ Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit ec13986
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/673452563c572400081c964e
😎 Deploy Preview https://deploy-preview-241--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jun 19, 2024 •
edited
Loading

✅ Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit ec13986
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/67345256cbd6f40008cbe1c7
😎 Deploy Preview https://deploy-preview-241--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 81.9 kB 28.5 kB 25.1 kB
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
runtime-vapor.global.prod.js 47.5 kB (+446 B) 18 kB (+179 B) 16.4 kB (+152 B)
vue-vapor.global.prod.js 47.5 kB (+446 B) 17.9 kB (+178 B) 16.4 kB (+151 B)
vue.global.prod.js 159 kB 57.9 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createVaporApp 27.5 kB (+446 B) 10.6 kB (+182 B) 9.71 kB (+157 B)
createSSRApp 59.2 kB 23 kB 21 kB
defineCustomElement 60 kB 22.9 kB 20.9 kB
overall 68.9 kB 26.4 kB 24 kB

@Doctor-wu Doctor-wu marked this pull request as draft June 19, 2024 14:43
@LittleSound
Copy link
Member

I have addressed a similar issue in PR #227. You can refer to the implementation of the normalizeSlotProps function.

I hope this information helps you solve the problem!

@Doctor-wu Doctor-wu marked this pull request as ready for review June 23, 2024 09:11
@Doctor-wu
Copy link
Member Author

Preview Demo

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 8, 2024 •
edited
Loading

Open in Stackblitz • playground

@vue/compiler-core

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-core@241

@vue/compiler-sfc

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-sfc@241

@vue/compiler-dom

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-dom@241

@vue/compiler-ssr

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-ssr@241

@vue/compiler-vapor

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compiler-vapor@241

@vue/reactivity

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/reactivity@241

@vue/runtime-core

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-core@241

@vue/runtime-dom

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-dom@241

@vue/runtime-shared

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-shared@241

@vue/runtime-vapor

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/runtime-vapor@241

@vue/server-renderer

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/server-renderer@241

@vue/shared

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/shared@241

vue

pnpm add https://pkg.pr.new/vuejs/vue-vapor/vue@241

@vue/compat

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/compat@241

@vue/vapor

pnpm add https://pkg.pr.new/vuejs/vue-vapor/@vue/vapor@241

commit: ec13986

@moushicheng
Copy link
Contributor

moushicheng commented Aug 28, 2024 •
edited
Loading

look good👍

@sxzz sxzz force-pushed the main branch 2 times, most recently from 2bf3c5e to 8ea6e4f Compare November 13, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slots level mess up
4 participants
@Doctor-wu @LittleSound @moushicheng @sxzz