Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): warn when slot used on non-root template #11569

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(compiler-core): warn when slot used on non-root template #11569

wants to merge 4 commits into from

Conversation

Disservin
Copy link
Contributor

Implements the warning from vue2 in vue3.

fixes #11521

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 33.9 kB
vue.global.prod.js 159 kB (+133 B) 57.6 kB (+68 B) 51.2 kB (+103 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.8 kB
defineCustomElement 59.8 kB 22.7 kB 20.7 kB
overall 68.8 kB 26.3 kB 23.9 kB

edison1105
edison1105 requested changes Aug 9, 2024
View reviewed changes
packages/compiler-core/src/parser.ts Outdated Show resolved Hide resolved
@edison1105 edison1105 added scope: compiler 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews labels Aug 9, 2024
@Disservin Disservin force-pushed the 11521-warn-about-incorrect-usage branch from 487e8f9 to 34c9f9c Compare August 15, 2024 16:33
@Disservin Disservin marked this pull request as draft August 15, 2024 17:00
@Disservin Disservin force-pushed the 11521-warn-about-incorrect-usage branch from 34c9f9c to cee2536 Compare August 15, 2024 18:12
@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024

❌ Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit cee2536
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/66be4527ca80f8000858a139

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024

❌ Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit cee2536
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66be4527894d820008a4ad9c

@Disservin Disservin force-pushed the 11521-warn-about-incorrect-usage branch 3 times, most recently from 5afe4ff to d57edf8 Compare August 15, 2024 18:18
@Disservin Disservin marked this pull request as ready for review August 15, 2024 18:18
@Disservin
fix(compiler-core): warn when slot used on non-root template
d13095b 
Implements the warning from vue2 in vue3.

fixes vuejs#11521
@Disservin Disservin force-pushed the 11521-warn-about-incorrect-usage branch from d57edf8 to d13095b Compare August 15, 2024 18:21
@Disservin
Copy link
Contributor Author

I moved it out of the parser and into the transform, I think this makes more sense?

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 16, 2024 •
edited
Loading

commit: 3e245ae

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11569

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11569

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11569

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11569

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11569

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11569

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11569

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11569

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11569

vue

pnpm add https://pkg.pr.new/vue@11569

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11569

Open in Stackblitz

@Disservin
fix(compiler-core): warn when slot used on non-root template
27ed27e 
Implements the warning from vue2 in vue3.

fixes vuejs#11521
@Disservin Disservin force-pushed the 11521-warn-about-incorrect-usage branch from c805254 to 27ed27e Compare August 16, 2024 18:58
@Disservin Disservin marked this pull request as draft August 19, 2024 08:42
@Disservin Disservin marked this pull request as ready for review August 19, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: When using template around template slot
2 participants
@Disservin @edison1105