Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-config and package.json version Upgrades #2

Open
shameerkc opened this issue Sep 11, 2016 · 2 comments
Open

system-config and package.json version Upgrades #2

shameerkc opened this issue Sep 11, 2016 · 2 comments

Comments

@shameerkc
Copy link

shameerkc commented Sep 11, 2016 •
edited
Loading

THANK YOU...

This has been the best available repository for understanding how Routing works. The official documentation is not there yet on RC3 Router.

Some minor changes are required for package.json and system-config.ts files. I have committed on the forked version. Please update the same as there are build errors.
@yaroslavya
Copy link

yaroslavya commented Sep 11, 2016 •
edited
Loading

Just tried your pull request, @shameerkc, worked for me. So it closes the issue I have created 👍
But can you make a pull request, @shameerkc so that it could just be merged into the main repo?

@yaroslavya yaroslavya mentioned this issue Sep 11, 2016
Open
@shameerkc
Copy link
Author

@yaroslavya Done... Pls check #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaroslavya @shameerkc