diff --git a/manifests/fpm.pp b/manifests/fpm.pp index c8dd31e5..455d9fdb 100644 --- a/manifests/fpm.pp +++ b/manifests/fpm.pp @@ -69,6 +69,7 @@ $log_owner = $php::log_owner, $log_group = $php::log_group, Boolean $pool_purge = $php::pool_purge, + Boolean $disable_configtest = false, ) { if ! defined(Class['php']) { diff --git a/manifests/fpm/config.pp b/manifests/fpm/config.pp index c255a853..9a0edb4f 100644 --- a/manifests/fpm/config.pp +++ b/manifests/fpm/config.pp @@ -103,12 +103,18 @@ default => $log_group, } + $validate_cmd = $php::fpm::disable_configtest ? { + true => undef, + default => $php::globals::fpm_checkconf_cmd, + } + file { $config_file: - ensure => file, - content => template('php/fpm/php-fpm.conf.erb'), - owner => root, - group => $root_group, - mode => '0644', + ensure => file, + content => template('php/fpm/php-fpm.conf.erb'), + owner => root, + group => $root_group, + mode => '0644', + validate_cmd => $validate_cmd, } ensure_resource('file', ['/var/run/php-fpm/', '/var/log/php-fpm/'], { diff --git a/manifests/fpm/pool.pp b/manifests/fpm/pool.pp index e7dcb213..bfd94734 100644 --- a/manifests/fpm/pool.pp +++ b/manifests/fpm/pool.pp @@ -190,14 +190,20 @@ notify => Class['::php::fpm::service'], } } else { + $validate_cmd = $php::fpm::disable_configtest ? { + true => undef, + default => $php::globals::fpm_checkconf_cmd, + } + file { "${pool_base_dir}/${pool}.conf": - ensure => file, - notify => Class['::php::fpm::service'], - require => Package[$real_package], - content => template($template), - owner => root, - group => $root_group, - mode => '0640', + ensure => file, + notify => Class['::php::fpm::service'], + require => Package[$real_package], + content => template($template), + owner => root, + group => $root_group, + mode => '0640', + validate_cmd => $validate_cmd, } } } diff --git a/manifests/globals.pp b/manifests/globals.pp index 8a800548..54b21eb5 100644 --- a/manifests/globals.pp +++ b/manifests/globals.pp @@ -51,6 +51,7 @@ $default_fpm_pid_file = "/var/run/php/php${globals_php_version}-fpm.pid" $fpm_error_log = '/var/log/php5-fpm.log' $fpm_service_name = 'php5-fpm' + $fpm_checkconf_cmd = '/usr/sbin/php5-fpm -t --fpm-config %' $ext_tool_enable = '/usr/sbin/php5enmod' $ext_tool_query = '/usr/sbin/php5query' $package_prefix = 'php5-' @@ -60,6 +61,7 @@ $default_fpm_pid_file = "/var/run/php/php${globals_php_version}-fpm.pid" $fpm_error_log = "/var/log/php${globals_php_version}-fpm.log" $fpm_service_name = "php${globals_php_version}-fpm" + $fpm_checkconf_cmd = "/usr/sbin/php-fpm${globals_php_version} -t --fpm-config %" $ext_tool_enable = "/usr/sbin/phpenmod -v ${globals_php_version}" $ext_tool_query = "/usr/sbin/phpquery -v ${globals_php_version}" $package_prefix = "php${globals_php_version}-" @@ -71,6 +73,7 @@ $default_fpm_pid_file = '/var/run/php5-fpm.pid' $fpm_error_log = '/var/log/php5-fpm.log' $fpm_service_name = 'php5-fpm' + $fpm_checkconf_cmd = '/usr/sbin/php5-fpm -t --fpm-config %' $ext_tool_enable = '/usr/sbin/php5enmod' $ext_tool_query = '/usr/sbin/php5query' $package_prefix = 'php5-' @@ -84,6 +87,7 @@ $default_fpm_pid_file = "/var/run/php/php${globals_php_version}-fpm.pid" $fpm_error_log = "/var/log/php${globals_php_version}-fpm.log" $fpm_service_name = "php${globals_php_version}-fpm" + $fpm_checkconf_cmd = "/usr/sbin/php-fpm${globals_php_version} -t --fpm-config %" $ext_tool_enable = "/usr/sbin/phpenmod -v ${globals_php_version}" $ext_tool_query = "/usr/sbin/phpquery -v ${globals_php_version}" $package_prefix = "php${globals_php_version}-" @@ -93,6 +97,7 @@ $default_fpm_pid_file = '/var/run/php5-fpm.pid' $fpm_error_log = '/var/log/php5-fpm.log' $fpm_service_name = 'php5-fpm' + $fpm_checkconf_cmd = '/usr/sbin/php5-fpm -t --fpm-config %' $ext_tool_enable = '/usr/sbin/php5enmod' $ext_tool_query = '/usr/sbin/php5query' $package_prefix = 'php5-'