rubocop: autofix

Author: bastelfreak

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+inherit_from: .rubocop_todo.yml
+
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 

.rubocop_todo.yml

@@ -0,0 +1,53 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2023-04-21 11:38:16 UTC using RuboCop version 1.50.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 6
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'puppet-lint-leading_zero-check.gemspec'
+    - 'spec/puppet-lint/plugins/check_leading_zero/check_leading_zero_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: Prefixes, AllowedPatterns.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/puppet-lint/plugins/check_leading_zero/check_leading_zero_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: IgnoredMetadata.
+RSpec/DescribeClass:
+  Exclude:
+    - '**/spec/features/**/*'
+    - '**/spec/requests/**/*'
+    - '**/spec/routing/**/*'
+    - '**/spec/system/**/*'
+    - '**/spec/views/**/*'
+    - 'spec/puppet-lint/plugins/check_leading_zero/check_leading_zero_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, conditionals
+Style/AndOr:
+  Exclude:
+    - 'lib/puppet-lint/plugins/check_leading_zero.rb'
+
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'lib/puppet-lint/plugins/check_leading_zero.rb'
+    - 'puppet-lint-leading_zero-check.gemspec'
+    - 'spec/puppet-lint/plugins/check_leading_zero/check_leading_zero_spec.rb'

lib/puppet-lint/plugins/check_leading_zero.rb

@@ -1,14 +1,14 @@
 PuppetLint.new_check(:leading_zero) do
   def check
     tokens.each do |token|
-      if token.type == :NUMBER and token.value =~ /^0\d/
-        notify :warning, {
-          :message => 'unquoted number with leading zero',
-          :line    => token.line,
-          :column  => token.column,
-          :token   => token,
-        }
-      end
+      next unless token.type == :NUMBER and token.value =~ /^0\d/
+
+      notify :warning, {
+        message: 'unquoted number with leading zero',
+        line: token.line,
+        column: token.column,
+        token: token,
+      }
     end
   end
 

puppet-lint-leading_zero-check.gemspec

@@ -11,7 +11,6 @@ Gem::Specification.new do |spec|
     'lib/**/*',
     'spec/**/*',
   ]
-  spec.test_files  = Dir['spec/**/*']
   spec.summary     = 'A puppet-lint plugin to check for unquoted numbers with leading zero.'
   spec.description = <<-EOF
     A puppet-lint plugin to check for unquoted numbers with leading zero.
@@ -20,9 +19,4 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.7.0'
 
   spec.add_dependency 'puppet-lint', '>= 3', '< 5'
-  spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rspec-its', '~> 1.0'
-  spec.add_development_dependency 'rspec-collection_matchers', '~> 1.0'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'rake'
 end

spec/puppet-lint/plugins/check_leading_zero/check_leading_zero_spec.rb

@@ -1,35 +1,35 @@
 require 'spec_helper'
 
 describe 'leading_zero' do
-  let (:msg) { 'unquoted number with leading zero' }
+  let(:msg) { 'unquoted number with leading zero' }
 
   context 'with fix disabled' do
     context 'no unquoted numbers with leading zero' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         $foo = '010'
         $bar = 10
         $baz = 0
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
     end
 
     context 'unquoted numbers with leading zero' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         $foo = 010
         EOS
-      }
+      end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should create a warning' do
+      it 'creates a warning' do
         expect(problems).to contain_warning(msg).on_line(1).in_column(16)
       end
     end
@@ -45,41 +45,41 @@
     end
 
     context 'no unquoted numbers with leading zero' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         $foo = '010'
         $bar = 10
         $baz = 0
         EOS
-      }
+      end
 
-      it 'should not detect any problems' do
+      it 'does not detect any problems' do
         expect(problems).to have(0).problems
       end
 
-      it 'should not modify the manifest' do
+      it 'does not modify the manifest' do
         expect(manifest).to eq(code)
       end
     end
 
     context 'unquoted numbers with leading zero' do
-      let (:code) {
+      let(:code) do
         <<-EOS
         $foo = 010
         EOS
-      }
+      end
 
-      it 'should detect a single problem' do
+      it 'detects a single problem' do
         expect(problems).to have(1).problem
       end
 
-      it 'should fix the problem' do
+      it 'fixes the problem' do
         expect(problems).to contain_fixed(msg).on_line(1).in_column(16)
       end
 
-      it 'should should use undef' do
+      it 'shoulds use undef' do
         expect(manifest).to eq(
-          <<-EOS
+          <<-EOS,
         $foo = '010'
           EOS
         )