Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with CodeMirror #11

Open
johnsoncodehk opened this issue Mar 3, 2023 · 5 comments
Open

Integration with CodeMirror #11

johnsoncodehk opened this issue Mar 3, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@johnsoncodehk
Copy link
Member

We have now completed the Monaco integration and when I checked @vue/repl I noticed it also uses another web code editor called CodeMirror, I was just considering whether it also needs LSP support.

The closest solution at the moment is codemirror-languageserver maintained by @hjr265.

But perhaps a compatibility package between Monaco worker and CodeMirror editor would be a better approach?

For now, I will keep this issue open but I may not do the work because I am not even sure if CodeMirror is still being used or maintained by the community.

@johnsoncodehk
Copy link
Member Author

Closed for the same reason as #12.

@johnsoncodehk
Copy link
Member Author

After re-investigating it I think it is not as difficult as imagined, we don't need to use codemirror-languageserver because we can directly access our own language service.

@johnsoncodehk johnsoncodehk reopened this Jun 24, 2023
@johnsoncodehk johnsoncodehk changed the title CodeMirror integration? Integration with CodeMirror Jun 24, 2023
@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Jun 24, 2023
@coder0107git
Copy link

coder0107git commented Feb 25, 2024

There's also this LSP integration for CodeMirror. It also supports LSP over Websockets but also support's running from a Web Worker. Another thing is that it has a LSP message support matrix (although I'm not sure how up-to-date it is).

Update: It looks like it only supports CodeMirror 5.

@johnsoncodehk
Copy link
Member Author

@coder0107git If you have a project that requires integrating Volar with CodeMirror6 please share it with me and we can assist with the integration while implementing the @volar/codemirror bridge.

@NullVoxPopuli
Copy link

NullVoxPopuli commented Mar 13, 2024

👋 I have an OSS-codemirror6-using project that I'd like to add Volar to 🎉 -- https://limber.glimdown.com / https://tutorial.glimdown.com
❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants