Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript "Move to a new file" code action not working for embedded documents #92

Open
johnsoncodehk opened this issue May 10, 2024 · 1 comment
Open

TypeScript "Move to a new file" code action not working for embedded documents #92

johnsoncodehk opened this issue May 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@johnsoncodehk
Copy link
Member

For non-ts files, getEditsForRefactor will hit the following assertion.

Error: Debug Failure. File /.../xxx.yyy has unknown extension.

This is hardcoded by TS in the internal variable extensionsToRemove, and there is currently no way to modify it.
@johnsoncodehk johnsoncodehk added the bug Something isn't working label May 10, 2024
@Princesseuh Princesseuh mentioned this issue May 13, 2024
Open
johnsoncodehk added a commit to johnsoncodehk/TypeScript that referenced this issue May 31, 2024
@johnsoncodehk
Try fix volarjs/services#92
85420bb
@louisgv
Copy link

louisgv commented Aug 23, 2024

Is it really not possible to fix this issue without patching TS? :-?... If so, I feel like we should tag the TS maintainer to ask or open an issue on TS to get their attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@louisgv @johnsoncodehk