this is my first pull request tips/advice is appreciated

sorry for not writing commit messages it is a bad habit, I just deleted the unused vars and prefixed the pkgdestdir var with an underscore because it is from the go build_style :)

sorry for not writing commit messages it is a bad habit, I just deleted the unused vars and prefixed the pkgdestdir var with an underscore because it is from the go build_style :)

You need to put the version number after the package name in the commit message. Also, you don't need hostmakedepends because of the build style.

# Template file for 'photon'
pkgname=photon
version=v1.0.1
revision=1
build_style=go
go_import_path=git.sr.ht/~ghost08/photon
short_desc="RSS reader as light as a photon with terminal + sixel"
maintainer="Emma Kadlecek <[email protected]>"
license="GPL-3.0-or-later"
homepage="https://git.sr.ht/~ghost08/photon"
distfiles="https://git.sr.ht/~ghost08/photon/archive/v${version}.tar.gz"
checksum=507ffe1903227f3ffab4f0d92ddb3ec49db34b285f276707606e23fb9eafe3c7

Do you mean the pull request name or should I add it when I make a new commit

Do you mean the pull request name or should I add it when I make a new commit

This

It should be something like this: 'New package: photon-1.0.1'. Keep this in mind for next time, and update the template accordingly.

Ok will do

You need to rebase to squash it into a single commit. The template name should not include a version number; it should just be the package name, like this:

# Template file for 'photon'
pkgname=photon
version=v1.0.1
revision=1
build_style=go
go_import_path=git.sr.ht/~ghost08/photon
short_desc="RSS reader as light as a photon with terminal + sixel"
maintainer="Emma Kadlecek <[email protected]>"
license="GPL-3.0-or-later"
homepage="https://git.sr.ht/~ghost08/photon"
distfiles="https://git.sr.ht/~ghost08/photon/archive/v${version}.tar.gz"
checksum=507ffe1903227f3ffab4f0d92ddb3ec49db34b285f276707606e23fb9eafe3c7

I don't know how to rebase it can you explain

I don't know how to rebase it can you explain

Check this, it should help a bit git rebase

The (n) represents the number of commits you've made. Basically, you keep the first one and change the others from (pick) to (squash).

Ok seems easy enough

Ok seems easy enough

Here is a quick tutorial.

ok full disclosure I have been doing most of this from a chromebook using github workspaces and it seems rebasing is funky on workspaces so I will rebase when I get home from school in about 3 hours

ok full disclosure I have been doing most of this from a chromebook using github workspaces and it seems rebasing is funky on workspaces so I will rebase when I get home from school in about 3 hours

Yeah, okay. After rebasing, just do a force push. git -f push

There is no need for:

CFLAGS="-fPIE -pie"
LDFLAGS="-fPIE -pie"
_PKGDESTDIR=${wrksrc}/destdir

BUMP