Retain installonlypkg install status on upgrade #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, I will take a look. One thing - can you fix these errors: I know, it's very pedantic... |
sameluch
force-pushed
the
sammeluch/fix-user-install-installonly
branch
from
f155e9e to
fbbaffa
Compare
No worries, resolved the errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #512
By iterating through the
ppszInstallOnlyPkgsduringTDNFMarkAutoInstalledwe can ensure that their install status is retained during upgrades (and installs that would pull in a new version of an installonlypkg). Since this only impacts packages configured in the installonlypkgs list in tdnf.conf, the impact is fairly low, and in most cases the list is very small, not requiring too many packages to check through.Additionally, I added a couple tests for the scenario.