Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensureDerived and updateRelations call each other too often #1422

Closed
sveneberth opened this issue Feb 22, 2025 · 0 comments · Fixed by #1428
Closed

ensureDerived and updateRelations call each other too often #1422

sveneberth opened this issue Feb 22, 2025 · 0 comments · Fixed by #1428
Labels
annoying bug(fix) Something isn't working or address a specific issue or vulnerability performance This issue or pull request enhances or criticizes the performance.

Comments

@sveneberth
Copy link
Member

sveneberth commented Feb 22, 2025

We have a loop in the ensureDerived and updateRelations.

Add a new derive size to your FileBone (image) --> Save the skeleton with it --> ensureDerived task is spawn --> ensureDerived generate new derive blob and calls updateRelations --> updateRelations saves the skeleton with the new derive meta --> FileBone postHandler calls ensureDerived again --> ensureDerived detects there is nothing to do.

The second ensureDerived call can be saved if the postHandler would know it's called from a updateRelations task caused by a ensureDerived change.

@sveneberth sveneberth added annoying bug(fix) Something isn't working or address a specific issue or vulnerability performance This issue or pull request enhances or criticizes the performance. labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annoying bug(fix) Something isn't working or address a specific issue or vulnerability performance This issue or pull request enhances or criticizes the performance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant