Adds Gulp and JSHint

Author: vitorbaptista

.jshintignore

@@ -0,0 +1,2 @@
+node_modules
+public/javascripts/vendor

.jshintrc

@@ -0,0 +1,3 @@
+{
+  "node": true
+}

cache.js

@@ -8,4 +8,4 @@ exports.createStore = function() {
     stdTTL: config.cache.ttl,
     useClones: false,
   });
-}
+};

config.js

@@ -6,14 +6,14 @@ config.env = process.env.NODE_ENV || 'development';
 
 config.express = {
   port: process.env.PORT || 3000,
-}
+};
 
 config.mongodb = {
   uri: process.env.MONGOLAB_URI || 'mongodb://localhost:27017/shellshare',
   capped_size_limit: 50 * 1024,  // 50 KB is more than enough for a full terminal screen
   authorizations_ttl: 86400,  // 1 day
-}
+};
 
 config.cache = {
   ttl: 3600,
-}
+};

db.js

@@ -4,7 +4,7 @@ var MongoClient = require('mongodb').MongoClient;
 
 var state = {
   db: null,
-}
+};
 
 exports.connect = function(url, done) {
   if (state.db) return done();
@@ -13,19 +13,19 @@ exports.connect = function(url, done) {
     if (err) return done(err);
     state.db = db;
     done();
-  })
-}
+  });
+};
 
 exports.get = function() {
   return state.db;
-}
+};
 
 exports.close = function(done) {
   if (state.db) {
     state.db.close(function(err, result) {
       state.db = null;
       state.mode = null;
       done(err);
-    })
+    });
   }
-}
+};

gulpfile.js

@@ -0,0 +1,10 @@
+'use strict';
+
+var gulp = require('gulp');
+var jshint = require('gulp-jshint');
+
+gulp.task('lint', function() {
+  gulp.src('./**/*.js')
+      .pipe(jshint())
+      .pipe(jshint.reporter('default'));
+});

models/authorization.js

@@ -57,4 +57,4 @@ function _upsertAuthorization(room, secret) {
 
 module.exports = {
   isAuthorized: isAuthorized,
-}
+};

models/rooms.js

@@ -31,7 +31,7 @@ function push(room, size, message, callback) {
 function all(room, callback) {
   _collection(room, function(collection) {
     collection.find({}).toArray(function(err, items) {
-      if (err || items.length == 0) {
+      if (err || items.length === 0) {
         callback(err, items);
       } else {
         var messageAscii = items.map(function (item) {
@@ -59,4 +59,4 @@ module.exports = {
   push: push,
   all: all,
   drop: drop,
-}
+};

package.json

@@ -12,10 +12,14 @@
     "body-parser": "1.14.1",
     "errorhandler": "1.4.2",
     "express": "4.13.3",
+    "gulp": "3.9.0",
     "jade": "1.11.0",
     "mongodb": "2.0.46",
     "morgan": "1.6.1",
     "node-cache": "3.0.0",
     "socket.io": "1.3.7"
+  },
+  "devDependencies": {
+    "gulp-jshint": "^1.11.2"
   }
 }

public/javascripts/room.js

@@ -13,7 +13,7 @@
     // FIXME: Ugly monkey patch to avoid term.js capturing the key presses,
     // as we're just using term.js as read-only. There should be a better way
     // to do this, but I couldn't find it.
-  }
+  };
 
   socket.emit('join', room);
   socket.on('usersCount', function (onlineUsers) {
@@ -56,7 +56,7 @@
     }
 
     currentSize = size;
-  };
+  }
 
   // Init terminal with a default size.
   onSize('{"cols": 80, "rows": 40}');

routes/rooms.js

@@ -15,10 +15,8 @@ router.get('/:room', function(req, res, next) {
 
 /* POST room. */
 router.post('/:room', function(req, res, next) {
-  var room = req.url;
-  var secret = req.get('Authorization');
-
-  authorizeOrDie(room, secret, function() {
+  authorizeOrDie(req, res, function() {
+    var room = req.url;
     var size = req.body.size;
     var message = req.body.message;
 
@@ -32,17 +30,18 @@ router.post('/:room', function(req, res, next) {
 
 /* DELETE room */
 router.delete('/:room', function(req, res, next) {
-  var room = req.url;
-  var secret = req.get('Authorization');
-
-  authorizeOrDie(room, secret, function() {
+  authorizeOrDie(req, res, function() {
+    var room = req.url;
     roomsModel.drop(room, function(err, col) {
     });
     res.sendStatus(202);
   });
 });
 
-function authorizeOrDie(room, secret, callback) {
+function authorizeOrDie(req, res, callback) {
+  var room = req.url;
+  var secret = req.get('Authorization');
+
   // FIXME: secret might be empty
   authorizationModel.isAuthorized(room, secret, function(authorized) {
     if (!authorized) {
@@ -105,4 +104,4 @@ module.exports = function(_roomPrefix, _io) {
 
   setupSockets();
   return router;
-}
+};