Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport #18112 and #18115 to v5.1 #18147

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

plchampigny
Copy link

@plchampigny plchampigny commented Sep 19, 2024

Copy link

stackblitz bot commented Sep 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@plchampigny plchampigny changed the title Backport 5.1 fix: backport #18112 and #18115 to v5.1 Sep 19, 2024
@plchampigny
Copy link
Author

@patak-dev can this fix be applied to the 5.1 branch? Angular v17 is depending on that version and its seems complicated to upgrade to 5.2.14: angular/angular-cli#28435 (comment)

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's do it. Thanks for sending the PR!

@patak-dev patak-dev merged commit 5caa08f into vitejs:v5.1 Sep 19, 2024
8 of 9 checks passed
@patak-dev
Copy link
Member

@plchampigny [email protected] has been released with the two fixes, and both CVEs patched version ranges have been updated. Thanks again!

@plchampigny
Copy link
Author

@plchampigny [email protected] has been released with the two fixes, and both CVEs patched version ranges have been updated. Thanks again!

Wow thanks for the fast merge @patak-dev !

@plchampigny plchampigny deleted the backport-5.1 branch September 19, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants