Alias :name/:csv with :keys/:values

[Pyrolistical]

consider this insert

await tx.none(
  `
    INSERT INTO "table"(
      $/row:name/
    )
    VALUES(
      $/row:csv/
    )
  `,
  {
    row: {
      column_1: 'value 1',
      column_2: 'value 2'
    }
  }
);

I think it would be more obvious we if we could write

await tx.none(
  `
    INSERT INTO "table"(
      $/row:keys/
    )
    VALUES(
      $/row:values/
    )
  `,
  {
    row: {
      column_1: 'value 1',
      column_2: 'value 2'
    }
  }
);

[vitaly-t]

You are formatting SQL Names, not SQL keys, i.e. you are confusing source with destination, i.e. each filter is named according to the expected result, not the type of source.

[Pyrolistical]

With pure functions, as these filters are, naming by either expected input or output is equivalent. Just purely an api design/stylistic choice.

IMO adding an alias is more inclusive to people who start with the input or start with the desired result first

[vitaly-t]

For stylistics, you can just wrap the query into a reusable function:

function insertObj(table: string, obj: any) {
    return pgp.as.format('INSERT INTO $1:name($2:name) VALUES($2:csv)', [table, obj]);
}

// and then use it like so:

await tx.none(insertObj('table', row));

[vitaly-t]

Also, a little simpler syntax:

await tx.none(
  `
    INSERT INTO "table"(
      $/this:name/
    )
    VALUES(
      $/this:csv/
    )
  `,
  {
      column_1: 'value 1',
      column_2: 'value 2'
    }
);