Fix dynamic favicon path handling for subdirectory pages

- Fixed issue with favicon path on subdirectory pages by dynamically extracting and updating favicon filename.
- Problem traced to previous commit 15f9065 which introduced static favicon path.
- Ensured favicon loads correctly across all pages in firefox.

Fixes sugarlabs#507

Author: vidipsingh

_layouts/base.html

@@ -4,7 +4,7 @@
         <meta charset="utf-8">
         <meta name="viewport" content="width=device-width, initial-scale=1">
         <meta http-equiv="X-UA-Compatible" content="IE=edge">
-        <link id="defaultIcon1" rel="shortcut icon" href="{{ site.baseurl }}assets/favicon_06.png" />
+        <link id="defaultIcon1" rel="shortcut icon" href="{{ site.baseurl }}/assets/favicon_06.png" />
         <title>{{ page.title }}</title>
         <link href="{{ site.baseurl }}/css/googleFonts.css" rel="stylesheet" type="text/css" >
         <meta name="robots" content="index,follow,NOODP" />

js/main.js

@@ -23,7 +23,13 @@ $(document).ready(function () {
         if (logoID < 10) {
             logoID = "0" + logoID;
         }
-        defaultIcon.href = 'assets/favicon_' + logoID + '.png';
+
+        // Extract the base path from the current favicon href
+        var currentHref = defaultIcon.getAttribute('href');
+        var basePath = currentHref.substring(0, currentHref.lastIndexOf('/') + 1);
+        
+        // Update only the filename portion while keeping the original path
+        defaultIcon.href = basePath + 'favicon_' + logoID + '.png';
     }
 
     var h = document.querySelector('.logo1').innerHTML;