Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review "conditional close" example parameters #95

Closed
veox opened this issue Jun 25, 2018 · 1 comment
Closed

Review "conditional close" example parameters #95

veox opened this issue Jun 25, 2018 · 1 comment
Labels

Comments

@veox
Copy link
Owner

veox commented Jun 25, 2018

Reported in #94 (search "sanity check") - the conditional close example might have become incompatible with the current Kraken API.

@veox veox added the examples label Aug 28, 2018
@veox
Copy link
Owner Author

veox commented Dec 3, 2020

The example is good - just tested again for issue #124.

The order's close[type] is determined automatically - it'll be complementary to type. So if type is buy, then close[type] is sell, and vice versa.

ordertype must be provided, although the list on Kraken's docs page is outdated. Currently available: limit, stop-loss, take-profit, stop-loss-limit, take-profit-limit, settle-position.

price and price2 depend on ordertype, as their docs say. Other keys in close[] still seem to be ignored.

@veox veox closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant