refactor: user properly aligned type for compressed lines storage

Author: variar

src/logdata/include/compressedlinestorage.h

@@ -20,7 +20,6 @@
 #include <array>
 #include <cstddef>
 #include <cstdint>
-#include <vector>
 
 #include "linetypes.h"
 #include <type_safe/strong_typedef.hpp>
@@ -39,12 +38,10 @@ class CompressedLinePositionStorage {
 
     // Copy constructor would be slow, delete!
     CompressedLinePositionStorage( const CompressedLinePositionStorage& orig ) = delete;
-    CompressedLinePositionStorage& operator=( const CompressedLinePositionStorage& orig )
-        = delete;
+    CompressedLinePositionStorage& operator=( const CompressedLinePositionStorage& orig ) = delete;
 
     CompressedLinePositionStorage( CompressedLinePositionStorage&& orig ) noexcept;
-    CompressedLinePositionStorage&
-    operator=( CompressedLinePositionStorage&& orig ) noexcept;
+    CompressedLinePositionStorage& operator=( CompressedLinePositionStorage&& orig ) noexcept;
 
     ~CompressedLinePositionStorage() = default;
 
@@ -89,7 +86,11 @@ class CompressedLinePositionStorage {
     };
 
     klogg::vector<BlockMetadata> blocks_;
-    klogg::vector<uint8_t> packedLinesStorage_;
+
+    struct alignas( 16 ) AlignedStorage {
+        std::array<uint8_t, 16> d;
+    };
+    klogg::vector<AlignedStorage> packedLinesStorage_;
 
     klogg::vector<OffsetInFile> currentLinesBlock_;
     klogg::vector<uint32_t> currentLinesBlockShifted_;
@@ -100,7 +101,7 @@ class CompressedLinePositionStorage {
     // Current position (position of the end of the last line added)
     OffsetInFile lastPos_;
 
-    bool canUseSimdSelect_ {false};
+    bool canUseSimdSelect_{ false };
 };
 
 #endif

src/logdata/src/compressedlinestorage.cpp

@@ -95,7 +95,7 @@ void CompressedLinePositionStorage::compress_current_block()
     block.packetBitWidth
         = static_cast<uint8_t>( simdmaxbitsd1( 0, currentLinesBlockShifted_.data() ) );
 
-    const size_t packedLinesSize = block.packetBitWidth * sizeof( __m128i );
+    const size_t packedLinesSize = block.packetBitWidth;
     packedLinesStorage_.resize( packedLinesStorage_.size() + packedLinesSize );
     block.packetStorageOffset = packedLinesStorage_.size() - packedLinesSize;