Skip to content
This repository has been archived by the owner on Feb 23, 2021. It is now read-only.

Source builds always build from valhalla master #54

Open
buildscientist opened this issue Jan 30, 2020 · 0 comments
Open

Source builds always build from valhalla master #54

buildscientist opened this issue Jan 30, 2020 · 0 comments

Comments

@buildscientist
Copy link

Not sure if this intentional but when invoking

./build.sh source <version> the Docker build will always pull the valhalla repo from master due to how script/install_from_source.sh does a git clone and invokes the build process without switching to the version passed to the Docker build script.

Is the version passed supposed to correspond to the version of Valhalla from source that will be built - or is that solely a tag for the Docker image?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant