TestBench for unit testing: add typed "selectItem"

[RSM-CWI]

As of now, the ComboBoxTester as well as RadioButtonGroupTester have the method
"selectItem(String)"
I understand that this makes sence from "user point of view" and if you migrate vom Vaadin testBench (selenium based).

But UnitTests are more whitebox tests instead of the blacl box selenium basted tests.

To I recommend, that there should be a typed "selectItem" method, wich accepts the actual values of the ComboBoxes as an alternativ.

In addidtion the _setValue() vor ComboBoxes and RadioButtonGroups in Karibu (you base on) accept the typed values, too!

The CheckBoxTester should have a "setValue" in addition. A "click()" and hope that'll toggle correctly is not that helpful in whitebox tests...

I'd appreciate this extension I assume that it will be helpful for most developers.

[mshabarov]

Thanks for the issue, could you please provide an example code that you have in mind for this use case and where you expect another way of selecting an item? Just for us to understand what use case we need to optimise.

[RSM-CWI]

Shure. Easy ;-)

Usually ComboBoxes are populated by Enums (sometimes by Entities...)

public enum Status {
  OPEN("Open", 1)
  CLOSED("Closed", 2)
  [...whatever...]
}

ComboBox<Status> statusFilterComboBox;
statusFilterComboBox.setItems(Status.values());

Now for the UnitTest:
Currently I have these 2 options:

test(myView.statusFilterComboBox).selectItem("Open");  // Hoping that "Open" is the correct String being displayed ;-)

or

myView.statusFilterComboBox.setValue(Status.OPEN); // Not really test code, but... ;-)

I would really preffer this, because UnitTesting is more whitebox-testing, so that would make more sense to me:

test(myView.statusFilterComboBox).selectItem(Status.OPEN);  

In addition Karibu allowed setting the value to the ComboBox as typed as above and not only Strings :-)

[mshabarov]

Makes sense to me. Thanks!