Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor _py3kInstructions to use dictionary of things to append #1096

Open
guyer opened this issue Feb 14, 2025 · 0 comments
Open

Refactor _py3kInstructions to use dictionary of things to append #1096

guyer opened this issue Feb 14, 2025 · 0 comments

Comments

@guyer
Copy link
Member

guyer commented Feb 14, 2025

As suggested by @wd15 in #1095 :

A lot of this code is of the form:

 if dis.opname[bytecode] == 'UNARY_CONVERT':
                    stack.append("`" + stack.pop() + "`")

It could be cleaned up by having a dictionary that relates UNARY_CONVERTER to what's inside the stack.append.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant