Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] RESTapi entrypoints can't be registered without queues/plugins/parameters #612

Open
3 tasks
andrewhand opened this issue Aug 16, 2024 · 1 comment · May be fixed by #613
Open
3 tasks

[BUG] RESTapi entrypoints can't be registered without queues/plugins/parameters #612

andrewhand opened this issue Aug 16, 2024 · 1 comment · May be fixed by #613
Assignees
@JustKuzya
Labels
bug Something isn't working

Comments

@andrewhand
Copy link
Contributor

andrewhand commented Aug 16, 2024 •
edited by JustKuzya
Loading

When registering an entrypoint with the api, the user should be able to register it without linking it to any:

  • queues,
  • plugins, or
  • parameters.

This currently produces an internal service error.

Definition of Done

  • Entrypoint registration and modify sub-endpoints should expect requests without queues/plugins/parameters listed
  • Test coverage is updated to include the issue
  • The feature is merged into dev
@andrewhand andrewhand added the bug Something isn't working label Aug 16, 2024
@andrewhand
Copy link
Contributor Author

andrewhand commented Aug 16, 2024 •
edited
Loading

dioptra/src/dioptra/restapi/v1/entrypoints/schema.py

Lines 126 to 156 in 63a29ea

class EntrypointMutableFieldsSchema(Schema):
"""The fields schema for the mutable data in a Entrypoint resource."""
name = fields.String(
attribute="name",
metadata=dict(description="Name of the Entrypoint resource."),
required=True,
)
description = fields.String(
attribute="description",
metadata=dict(description="Description of the Entrypoint resource."),
load_default=None,
)
taskGraph = fields.String(
attribute="task_graph",
metadata=dict(description="Task graph of the Entrypoint resource."),
required=True,
)
parameters = fields.Nested(
EntrypointParameterSchema,
attribute="parameters",
many=True,
metadata=dict(description="List of parameters for the entrypoint."),
)
queueIds = fields.List(
fields.Integer(),
attribute="queue_ids",
data_key="queues",
metadata=dict(description="The queue for the entrypoint."),
load_only=True,
)

Field queueIds needs a default value set to an empty list.

@andrewhand andrewhand self-assigned this Aug 16, 2024
@andrewhand andrewhand linked a pull request Aug 16, 2024 that will close this issue
V1 fix entrypoint schema #613
Open
@keithmanville keithmanville changed the title [BUG] RESTapi entrypoints can't be registered without queues [BUG] RESTapi entrypoints can't be registered without queues/plugins/parameters Jan 13, 2025
@keithmanville keithmanville mentioned this issue Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JustKuzya JustKuzya

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V1 fix entrypoint schema usnistgov/dioptra
2 participants
@JustKuzya @andrewhand