Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace dictionaries of parameters with bespoke Dataclasses or Pydantic objects #98

Open
pbeaucage opened this issue Aug 8, 2023 · 0 comments

Comments

@pbeaucage
Copy link
Collaborator

At several points in PyHyper, most notably integration parameters, opaque dictionaries of flexible parameters are used to switch between several different methods, e.g. Nika vs PyFAI geometries.

It would be more robust and usable if these were replaced with a Dataclass that validated complete inputs and provided state management for the integrator.

Other than a discussion item, the main to-do is find other examples where we use dictionaries of parameters to consider conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant