Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: In Charts component (chart-donut) showTooltip, showLegend props are working, As these are not getting handled in the component #969

Open
1 of 2 tasks
hitendra2f opened this issue Dec 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hitendra2f
Copy link

Reproduction

https://www.shadcn-vue.com/docs/charts/donut.html

Describe the bug

In Charts component (chart-donut) showTooltip, showLegend props are working, As these are not getting handled in the component

System Info

chart-donut

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@hitendra2f hitendra2f added the bug Something isn't working label Dec 18, 2024
@Saeid-Za
Copy link
Contributor

Hello There !
You are right, showLegend is useless here, because we have no legend defined in DonutChart and showTooltip although defined, is never used to conditionality render the tooltip.
Waiting for further confirmation @sadeghbarati
You are more than welcome to help us fix this issue after this is confirmed !

@sadeghbarati
Copy link
Collaborator

I'm not familiar with Charts stuff

IIRC, Zernonia will refactor the Charts so it can be aligned with the main shadcn-ui Chart props

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants