Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ToggleGroup was failing when 'string' as modelValue is used. #1553

Open
ucyildirim opened this issue Jan 11, 2025 · 1 comment · May be fixed by #1554
Open

[Bug]: ToggleGroup was failing when 'string' as modelValue is used. #1553

ucyildirim opened this issue Jan 11, 2025 · 1 comment · May be fixed by #1554
Labels
bug Something isn't working need-reproduction Issue is lacking reproduction. Will be close if not provided.

Comments

@ucyildirim
Copy link
Contributor

Environment

environment does not matter.

Link to minimal reproduction

Steps to reproduce

use string as modelValue for ToggleGroup.

Describe the bug

ToggleGroup was failing when 'string' as modelValue is used.

radix-vue/packages/radix-vue/src/ToggleGroup/ToggleGroupItem.vue

Line 26 in 194bf4b

const pressed = computed(() => rootContext.modelValue.value?.includes(props.value))

PR is submitted.

Expected behavior

No response

Context & Screenshots (if applicable)

No response
@ucyildirim ucyildirim added the bug Something isn't working label Jan 11, 2025
ucyildirim added a commit to ucyildirim/radix-vue that referenced this issue Jan 11, 2025
@ucyildirim
fixes unovue#1553
505343b
@ucyildirim ucyildirim linked a pull request Jan 11, 2025 that will close this issue
Open
@zernonia
Copy link
Member

Please provide a reproduction @ucyildirim .

It seems to be working fine https://www.radix-vue.com/components/toggle-group.html

@zernonia zernonia added the need-reproduction Issue is lacking reproduction. Will be close if not provided. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need-reproduction Issue is lacking reproduction. Will be close if not provided.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ToggleGroup was failing when 'string' as modelValue is used ucyildirim/radix-vue
2 participants
@ucyildirim @zernonia