Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support raw methods for azure-storage-blob #441

Open
blowsie opened this issue May 8, 2024 · 2 comments
Open

support raw methods for azure-storage-blob #441

blowsie opened this issue May 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@blowsie
Copy link

blowsie commented May 8, 2024

Environment

Any / All

Reproduction

https://github.com/unjs/unstorage/blob/main/src/drivers/azure-storage-blob.ts#L96

Describe the bug

Calling .toString() here is problematic, as the getItem function can longer be used with buffers.

My suggestion would be to allow a type to be passed to the getItem() fn, or remove the toString() call and allow developers to call that manually, when they choose.

Additional context

No response

Logs

No response
@pi0
Copy link
Member

pi0 commented May 8, 2024

Hi. We have getItemRaw that can be implemented and return the buffer/raw value. PR welcome to add that.

@pi0 pi0 changed the title azure-storage-blob getItem prematurely calls .toString() support raw methods for azure-storage-blob May 8, 2024
@pi0 pi0 added the enhancement New feature or request label May 8, 2024
@blowsie
Copy link
Author

blowsie commented May 8, 2024

Will do thanks!

refs ##142

@blowsie blowsie mentioned this issue May 8, 2024
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blowsie @pi0