Skip to content

Commit 6208334

Browse files
committed
fix(node): hook calling order
1 parent a15b8de commit 6208334

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

src/adapters/node.ts

+5-7
Original file line numberDiff line numberDiff line change
@@ -66,20 +66,18 @@ export function toNodeListener(app: App): NodeListener {
6666
// #754 Make sure hooks see correct status code and message
6767
setResponseStatus(event, error.statusCode, error.statusMessage);
6868

69+
if (app.options.onBeforeResponse && !event._onBeforeResponseCalled) {
70+
await app.options.onBeforeResponse(event, { body: error });
71+
}
6972
if (app.options.onError) {
7073
await app.options.onError(error, event);
7174
}
72-
if (event.handled) {
73-
return;
74-
}
7575
if (error.unhandled || error.fatal) {
7676
console.error("[h3]", error.fatal ? "[fatal]" : "[unhandled]", error);
7777
}
78-
79-
if (app.options.onBeforeResponse && !event._onBeforeResponseCalled) {
80-
await app.options.onBeforeResponse(event, { body: error });
78+
if (!event.handled) {
79+
await sendError(event, error, !!app.options.debug);
8180
}
82-
await sendError(event, error, !!app.options.debug);
8381
if (app.options.onAfterResponse && !event._onAfterResponseCalled) {
8482
await app.options.onAfterResponse(event, { body: error });
8583
}

0 commit comments

Comments
 (0)