-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt cabal build to lts-20.26 #4203
Conversation
@jneira Hey thanks for the update. We are actually on lts-20.26 now; does that change anything? |
I don't think so, I only checked the lts versions to help to discover the needed version bounds in cabal.project and they have not changed afaics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jneira Actually could you just add
{-# GHC_OPTIONS -Wno-deprecations #-}
to unison-share-projects-api/src/Unison/Share/API/Hash.hs
instead of hiding deprecation warnings globally.
At first I was thinking it was fine as-is and we can get the deprecated call removed quickly; but just to be safe, I'd rather minimize the scope of the hidden warnings.
@aryairani sure, that was my firts idea but i was not sure if touching a source file only due to a temporary package bound was a good one. If we think about what will happen when the stack build reach the jose version with derecations:
But as you consider, both alternatives have caveats (as usual 😝) |
@jneira Oof, I see. I was a little mixed up and didn't notice that the deprecation warning was only set in I will ask @mitchellwrosen or @tstat to weigh in, but I guess it's fine with me as-is in this case. I also added #4212 to try to stop using |
Co-authored-by: Travis Staton <[email protected]>
Since the recent upgrade of main stack build to lts-20.22 , the default constraints of cabal solver (get the newer versions) makes the build fail
This pr adds the required constraints, got from https://www.stackage.org/lts-20.22
It also ignores deprecations for
unison-share-projects-api
cause getting a working version of jose package is very difficult only touching cabal.project due to package revisionsTested manually with
cabal build all --project-file .\contrib\cabal.project -w ghc-9.2.8
Building with ghc-8.10.7 fails with:
i think it would be not too difficult to workaround that error but i guess that build is unsupported, so 🤷