Property Type Alias field is missing max-length validation

[danielhnelson]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.6.0

Bug summary

When a back office user tries to save a Property Type Alias that is more that 255 characters long, they will see the following error:

This can be a problem when property names need to be particularly long, and the user has not set a specific Alias, instead letting the Alias be auto-generated.

I have fixed this issue locally by amending the Alias property on the PropertyTypeBasic Class to include a MaxLength attribute, which instead produces a specific validation warning on save.

I intend to open a PR to apply that fix soon. 😊

Specifics

I've seen this issue on an Umbraco 8.9.0 website, a 13.6.0 site and reproduced locally with the v13/contrib branch. This may not be relevant in V14+ as the PropertyTypeBasic class isn't present in that.

Steps to reproduce

1. Create a new Document Type
2. Add a Property to it with a very long name (larger than 255 characters)

3. Save the Document Type
4. You will see the previously described exception message

Expected result / actual result

Expected Result:
Meaningful validation on the field, similar to the 'Invalid alias' warning that is shown for users who use invalid characters

Actual Result:
Exception that is large and disruptive for the user, and requires interpretation to understand what has caused the problem.

[github-actions]

Hi there @danielhnelson!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[AndyButland]

Thanks for reporting @danielhnelson, and yes, a PR to v13/contrib would be appreciated for this.

[github-actions]

Hi @danielhnelson,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)