fix a bug in under sign on characters

Author: kaikalii

src/algorithm/pervade.rs

@@ -1263,6 +1263,54 @@ pub mod mul {
     }
 }
 
+pub mod set_sign {
+    use super::*;
+
+    pub fn num_num(a: f64, b: f64) -> f64 {
+        mul::num_num(a, b.abs())
+    }
+    pub fn byte_byte(a: u8, b: u8) -> f64 {
+        num_num(a as f64, b as f64)
+    }
+    pub fn byte_num(a: u8, b: f64) -> f64 {
+        num_num(a as f64, b)
+    }
+    pub fn num_byte(a: f64, b: u8) -> f64 {
+        num_num(a, b as f64)
+    }
+    pub fn num_char(a: f64, b: char) -> char {
+        if a > 0.0 {
+            scalar_abs::char(b)
+        } else if a < 0.0 {
+            scalar_neg::char(scalar_abs::char(b))
+        } else {
+            b
+        }
+    }
+    pub fn char_num(a: char, b: f64) -> char {
+        num_char(b, a)
+    }
+    pub fn byte_char(a: u8, b: char) -> char {
+        if a > 0 {
+            scalar_abs::char(b)
+        } else {
+            b
+        }
+    }
+    pub fn char_byte(a: char, b: u8) -> char {
+        byte_char(b, a)
+    }
+    pub fn com_x(a: Complex, b: impl Into<Complex>) -> Complex {
+        a.normalize() * b.into()
+    }
+    pub fn x_com(a: impl Into<Complex>, b: Complex) -> Complex {
+        a.into().normalize() * b
+    }
+    pub fn error<T: Display>(a: T, b: T, env: &Uiua) -> UiuaError {
+        env.error(format!("Cannot set sign of {b} to {a}"))
+    }
+}
+
 pub mod div {
     use super::*;
     pub fn num_num(a: f64, b: f64) -> f64 {

src/compile/invert/under.rs

@@ -120,7 +120,7 @@ static UNDER_PATTERNS: &[&dyn UnderPattern] = &[
     &DupPat,
     // Sign ops
     &Stash(1, Abs, (Sign, Mul)),
-    &Stash(1, Sign, (Abs, Mul)),
+    &Stash(1, Sign, (Flip, SetSign)),
     // Mod
     &MaybeVal((
         Modulus,

src/primitive/defs.rs

@@ -3386,6 +3386,7 @@ impl_primitive!(
     ([2], UnBracket),
     ([1], UndoRows),
     ([1], UndoInventory),
+    (2, SetSign),
     // Optimizations
     (1, FirstMinIndex),
     (1, FirstMaxIndex),

src/primitive/mod.rs

@@ -269,6 +269,7 @@ impl fmt::Display for ImplPrimitive {
             UndoRows => write!(f, "{Under}{Rows}"),
             UndoInventory => write!(f, "{Under}{Inventory}"),
             MaxRowCount(n) => write!(f, "MaxRowCount({n})"),
+            SetSign => write!(f, "{Under}{Sign}"),
             // Optimizations
             FirstMinIndex => write!(f, "{First}{Rise}"),
             FirstMaxIndex => write!(f, "{First}{Fall}"),
@@ -1538,6 +1539,7 @@ impl ImplPrimitive {
                 }
                 env.push(max_len.unwrap_or(1));
             }
+            ImplPrimitive::SetSign => env.dyadic_oo_env(Value::set_sign)?,
             // Optimizations
             ImplPrimitive::FirstMinIndex => env.monadic_ref_env(Value::first_min_index)?,
             ImplPrimitive::FirstMaxIndex => env.monadic_ref_env(Value::first_max_index)?,

src/value.rs

@@ -1930,6 +1930,13 @@ value_bin_math_impl!(
     (Char, Byte, char_byte),
     [|meta| meta.flags.is_boolean(), Byte, bool_bool],
 );
+value_bin_math_impl!(
+    set_sign,
+    (Num, Char, num_char),
+    (Char, Num, char_num),
+    (Byte, Char, byte_char),
+    (Char, Byte, char_byte),
+);
 value_bin_math_impl!(div, (Num, Char, num_char), (Byte, Char, byte_char),);
 value_bin_math_impl!(modulus, (Complex, Complex, com_com));
 value_bin_math_impl!(or, [|meta| meta.flags.is_boolean(), Byte, bool_bool]);

tests/under.ua

@@ -231,6 +231,12 @@
 ⍤⤙≍ ¯5 ⍜±∘ ¯5
 ⍤⤙≍ 10 ⍜±(+1) 5
 ⍤⤙≍ ¯10 ⍜±(-1) ¯5
+⍤⤙≍ @A ⍜±⋅1 @a
+⍤⤙≍ @a ⍜±⋅0 @a
+⍤⤙≍ @a ⍜±⋅¯1 @a
+⍤⤙≍ @A ⍜±⋅1 @A
+⍤⤙≍ @A ⍜±⋅0 @A
+⍤⤙≍ @a ⍜±⋅¯1 @A
 
 ⍤⤙≍ [6 7 18] ⍜◿(×2) 5 [3 6 14]